Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Automatic release from branch v* #1358

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

daquinteroflex
Copy link
Collaborator

Hi Momchil,

I've improved the release process.

So now:

  • You make a branch in tidy3d/ that starts with the letter "v" like this example branch
  • When you commit to this branch, the sync-to-readthedocs action will automatically make a branch in tidy3d-docs with the same name
  • It will push the contents into that branch.

You can see this worked well:

Then you can easily just build the documentation for that branch in the readthedocs admin page.

(I am unsure what happens when it is overwritten)

@momchil-flex
Copy link
Collaborator

What is your motivation for this? I thought it was already good enough in that I both develop and pre/ branches are synced, so I can just build the docs from the top level of those. I guess the idea of this addition is that I could try any earlier state too, right?

@daquinteroflex
Copy link
Collaborator Author

daquinteroflex commented Jan 8, 2024

I realized that it was going to be a pain to do what I did before. So before, it is synced, but you have to manually create a branch on both repos.

Before, you had to manually create a branch on two repositories, but to do that you had to push manually to the tidy3d-docs repo. So this action didn't really make sense until now. Now, you just have to make a branch that starts with a v, and it does the rest for you in terms of pushing and I think syncing.

I think I need to extend the action to maybe every branch that triggers it, ie pre/ v/ though now that you mention it too

@momchil-flex
Copy link
Collaborator

momchil-flex commented Jan 8, 2024

Ok I see what you mean, this PR does more than just add the v_ capability. It also makes sure that a new branch is created in the tidy3d-docs repo. Right?

@daquinteroflex daquinteroflex force-pushed the v_test_release branch 2 times, most recently from 8c224d1 to 392d7d5 Compare January 8, 2024 19:39
@daquinteroflex
Copy link
Collaborator Author

Yeah that's the idea. However, I've now updated the github action for it to be any branch.

Now, I'm doing two things here you might need for the release so you might need to merge this PR for the full release to work:

  • I am updating the linked submodule state of tidy3d/docs to the latest commit history in pre/2.6 I just refactored
  • I am updating the deployment action for the branch thing.
  • Docs are building locally as we speak

@daquinteroflex
Copy link
Collaborator Author

daquinteroflex commented Jan 8, 2024

Local docs are looking good. @momchil-flex feel free to review. It's ready to merge imo.

The release flow is as follows:

  • The release flow just involves making a branch now either pre* or v* in tidy3d frontend. This branch will propagate automatically, and you should be able to just click build documentation branch from the readthedocs control panel.

@momchil-flex momchil-flex force-pushed the v_test_release branch 2 times, most recently from a063988 to 9d21390 Compare January 8, 2024 21:48
@momchil-flex momchil-flex merged commit fa40288 into pre/2.6 Jan 8, 2024
19 checks passed
@momchil-flex momchil-flex deleted the v_test_release branch January 8, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants