DataArray accepts file path and handle #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
force-pushed
the
tyler/fix/data_array_to_hdf5
branch
from
8df5d67
to
573bc61
Compare
e-g-melo
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Thanks @tylerflex!
Both options are working very well in the code below now.
Nx = 1
Ny = 10
Nz = 11
x = [0]
y = np.linspace(-Ly / 2, Ly / 2, Ny)
z = [0]
coords = dict(x=x, y=y, z=z)
xgrid, ygrid, zgrid = np.meshgrid(x, y, z, indexing="ij")
phase = td.SpatialDataArray(2 * np.pi * ygrid / Ly, coords=coords)
phase.to_hdf5("phase_file.hdf5", group_path="phase")
with h5.File("phase_handle.hdf5", "w") as f:
phase.to_hdf5(f, group_path="phase")
momchil-flex
approved these changes
Jan 15, 2024
|
I dont think it's urgent. let's just do 2.6 for simplicity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly, the docstring made it look like to save a
DataArray, one should pass afname: str. However, the function internals accept an h5py file handle and this method is called as such, internally.This PR makes
DataArray.to_hdf5()work either when passed a file name or a file handle.