FIX: Github action VENV management to prevent the bug in #1457, python 3.8 fundamental depreciation #1469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to sort out the github action issue in #1457 without bothering everyone.
The error that made the github actions fail was:
This PR is actually a pretty strong rewrite of the way the github action used to work:
poetry.lock
for python 3.8 because there are no supported jax for 3.8. This does not concern the extra jax, I refer to the full environment management compiled in poetry.lock cannot even be created for python 3.8 since there is no resolved envrionment for a given set of platforms. I don't think it's possible to say that python 3.8 is supported in the pyproject.toml just for ubuntu and linux.Unfortunately I think we fundamentally need to depreciate python 3.8. It probably wasn't even working before on Windows but the venv caching hid that from us. It is not possible to generate a resolved poetry.lock environment, independent of the extras installation mechanism. Like in any case any 3.8 installation is broken in windows at some level, and not being able to generate the poetry.lock environment is just trying to avoid us from users dealing with that.