improving docstrings for Point-, Cell-, and IndexedDataArrays #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dbochkov-flexcompute
commented
Feb 20, 2024
dbochkov-flexcompute
commented
- changelog related to https://github.com/flexcompute/tidy3d-core/pull/536
CHANGELOG.md
Outdated
| @@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Helpful error message if `val` supplied to `SimulationData.plot_field` not supported. | |||
| - Fixed validator that warns if angled plane wave does not match simulation boundaries, which was not warning for periodic boundaries. | |||
| - Validates that no nans are present in `DataArray` values in custom components. | |||
| - Removed nans from Cartesian temperature monitors in thermal simulations. | |||
There was a problem hiding this comment.
Maybe clarify how they are removed (interpolating nearest)
tylerflex
approved these changes
Feb 20, 2024
tylerflex
approved these changes
Feb 20, 2024
dbochkov-flexcompute
force-pushed
the
daniil/docstring-fixes
branch
from
17455e9
to
2252c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.