-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch refactoring / multi-threading #1630
Conversation
73c1d02
to
10d3ca8
Compare
6a99c99
to
8cb0731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks great, excited to test this!
e71b355
to
b2004f2
Compare
Thanks @lei-flex @daquinteroflex @lucas-flexcompute for the comments. Let me know if you think this needs more review or work on any particular aspects, thanks! |
b2004f2
to
00808c9
Compare
…icit .upload() methods.
5fbe7c5
to
57457b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it.
57457b7
to
dcd91c5
Compare
Goals:
Batch
andJob
work internally.Batch
.Refactor
Previously,
Job
objects were defined like thisThis meant that when you created a
Job
, the task is immediately uploaded.Also when you save a
Job.to_file()
the task info is contained.This design made it a bit annoying to do normal multi-threading over job upload.
In the refactored version, I set it up to have
upload
in its own method.Now a similar refactoring was done for
Batch
to move theupload()
bits to their own method.Before, the
Batch
created allJob
objects and uploaded them at initialization time in a validator.instead, now that we have the
Job
with its ownupload
method, I simplified this to.Multithreading
Implemented basic multi-threading for
Batch.upload()
andBatch.download()
. Works as expected on the Design plugin notebook.Also made it so that
Batch.run()
will download by default.Output / Logging