Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 FIX: bumpmyversion pyproject.toml match #1632

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

daquinteroflex
Copy link
Collaborator

I've tested it and it seems to work as I expect

@momchil-flex
Copy link
Collaborator

It seems like you are updating the notebooks submodule to a 2.7 state here (there's an EME notebook), but for some reason the test-latest-submodules pass even though you're asking to merge this in develop?

@daquinteroflex
Copy link
Collaborator Author

It was a nunanced implementation reason why it was not failing, but it's failing correctly now https://github.com/flexcompute/tidy3d/actions/runs/8817620572/job/24204477926

@daquinteroflex daquinteroflex changed the base branch from develop to pre/2.7 April 24, 2024 16:19
@tylerflex tylerflex added the 2.7 will go into version 2.7.* label Apr 25, 2024
@momchil-flex momchil-flex merged commit 844bcf8 into pre/2.7 Apr 25, 2024
16 checks passed
@momchil-flex momchil-flex deleted the dario/fix_bumpmyversion branch April 25, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants