fix plotting of 2d objects #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Implementation looks good. A question about changing the intersections_tilted_plane method name. Do we need to do this? I'm worried it will cause complications but am not sure about specifically where this would come up.
If we do change it, we might want to deprecate that method first (eg. call the _do_intersections_tilted_plane, but log a warning?
|
Can you also add a changelog item? thanks |
dmarek-flex
force-pushed
the
dmarek/fix_display_2D_objects
branch
from
55bf5f4
to
790936f
Compare
tylerflex
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and issue with plotting
Transformedobjects that happen to have 0 thickness. The problem was that no intersections were found when using Trimesh to compute intersections. This is because all of the triangles were directly coincident on the intersection plane. This will not happen for fully 3D geometries.I fixed it by reverting to simple intersection computations when the plane happens to be aligned with an axis. Another option would have been to give the object a very small thickness before meshing.
With this fix, I can correctly display geometries like: