extra geometries for 2d material #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarek-flex
added
improvement
awaiting backend
dmarek-flex
force-pushed
the
dmarek/extra_geometries_for_2d_material
branch
4 times, most recently
from
92b5959
to
780a925
Compare
tylerflex
approved these changes
May 2, 2024
dmarek-flex
force-pushed
the
dmarek/extra_geometries_for_2d_material
branch
from
780a925
to
70055dc
Compare
weiliangjin2021
approved these changes
May 6, 2024
dmarek-flex
force-pushed
the
dmarek/extra_geometries_for_2d_material
branch
from
70055dc
to
54a135d
Compare
dmarek-flex
force-pushed
the
dmarek/extra_geometries_for_2d_material
branch
from
54a135d
to
4b5c717
Compare
|
I made the modifications that @tylerflex suggested in the coaxial ports PR |
dmarek-flex
force-pushed
the
dmarek/extra_geometries_for_2d_material
branch
3 times, most recently
from
7894b82
to
aeb2594
Compare
tylerflex
approved these changes
May 9, 2024
There was a problem hiding this comment.
Looks much better I think! Thanks @dmarek-flex. Couple minor comments
added validation tests for structures with 2d materials and methods for updating bounds of certain geometries
dmarek-flex
force-pushed
the
dmarek/extra_geometries_for_2d_material
branch
from
aeb2594
to
d78268a
Compare
|
Thanks @tylerflex for finding those lingering issues. I'll merge this when all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability for Transformed/GeometryGroup/ClipOperation geometries to be composed of 2D materials.
Solves issue 576