📦 BUILD: Fix the trigger develop cli action to sync branches #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquinteroflex
force-pushed
the
dario/fix_trigger_develop_action
branch
from
0268843
to
6483184
Compare
daquinteroflex
force-pushed
the
dario/fix_trigger_develop_action
branch
from
6e28572
to
218fd8f
Compare
|
Since we merged #1650 to pre/2.7, this here is only relevant if we want to make a 2.6.5 right? |
|
Unfortunately, this PR is relevant if we want all develop-cli tests to pass on all branches including pre-/2.7. This is becuase of the way that the "trigger" action occurs when the "run tests" workflow has completed. It can only trigger if the action is in the main branch. However, our action in the main develop branch had a bug that it was only checking out the develop branch, rather than the branch that triggered the action on the tidy3d-develop-cli action. This PR fixes that. |
|
Ah ok. |
|
@tylerflex you're marked as reviewer here |
tylerflex
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I think we need to merge this as soon as we can in order for the develop actions to begin running from the branch that triggered the build.
Also I found a bug on tidy3d-develop-cli that was testing the develop installation only on the develop branch, but not on the actual branches where the commit was created in which I'm fixing.
Note that the develop action won't be fixed until we merge this into develop