Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax smallest triangle area in TriangleMesh to 1e-36 #1679

Merged
merged 1 commit into from
May 9, 2024

Conversation

weiliangjin2021
Copy link
Collaborator

@weiliangjin2021 weiliangjin2021 commented May 3, 2024

It's relaxed to the minimal positive normal 32-float number

@weiliangjin2021 weiliangjin2021 added 2.7 will go into version 2.7.* rc2 2nd pre-release awaiting backend not to be merged as backend is not finalized labels May 3, 2024
@weiliangjin2021
Copy link
Collaborator Author

One question @caseyflex : do we really need to worry about zero area at all? If the area is too small, it can be just left out.

@weiliangjin2021
Copy link
Collaborator Author

One question @caseyflex : do we really need to worry about zero area at all? If the area is too small, it can be just left out.

I probably find the answer myself: if the entire surface is very small so that almost every triangle is ignored, it'll be severely off.

@caseyflex
Copy link
Contributor

One question @caseyflex : do we really need to worry about zero area at all? If the area is too small, it can be just left out.

I probably find the answer myself: if the entire surface is very small so that almost every triangle is ignored, it'll be severely off.

I see, I had wondered about this earlier too, but yeah that case could definitely occur.

@weiliangjin2021 weiliangjin2021 changed the title Relax smallest triangle area in TriangleMesh to 1e-40 Relax smallest triangle area in TriangleMesh to 1e-36 May 6, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@weiliangjin2021 weiliangjin2021 merged commit 5c8825a into pre/2.7 May 9, 2024
15 of 16 checks passed
@weiliangjin2021 weiliangjin2021 deleted the weiliang/STL branch May 9, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.* awaiting backend not to be merged as backend is not finalized rc2 2nd pre-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants