More tests and safety checks for autograd module #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Looks good, only thing is the string formatting consistency with our existing code.
Variable names in stuff to STDOUT (like the "size" in size must be an iterable) should be in single quotes '.
Also we tend to use sentence case (?) in our exceptions and error messages, so please add period at the end.
Otherwise looks good! Thanks
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-plugin-tests
branch
from
b8ac467
to
db8a536
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-plugin-tests
branch
from
db8a536
to
4d08159
Compare
…s well as tests for utilities
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-plugin-tests
branch
from
4d08159
to
869c224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.