Differentiable n-dimensional nearest and linear interpolation for DataArray
#1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-interp
branch
from
0ced3b6
to
0162bcc
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-interp
branch
from
61f33e4
to
02fd006
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-interp
branch
2 times, most recently
from
e4fcb00
to
adcdf69
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-interp
branch
2 times, most recently
from
dfa68bb
to
511e3be
Compare
tylerflex
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Thanks @yaugenst-flex , let's discuss these last few things but overall looks great
dmarek-flex
reviewed
Jul 3, 2024
dmarek-flex
reviewed
Jul 3, 2024
…not defined for ArrayBox
…e old 0-size monitor dim behavior
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-interp
branch
from
d9ea683
to
c96525a
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/autograd-interp
branch
from
c96525a
to
ff75702
Compare
tylerflex
approved these changes
Jul 4, 2024
| return anp.sum(data[monitor.name].flux.values) | ||
| elif objtype == "intensity": | ||
| return anp.sum(data.get_intensity(monitor.name).values) | ||
|
|
There was a problem hiding this comment.
in view of the notebook failing, maybe we need to add a parameterize for the size of the monitor (planar vs point?)
|
|
||
| @pytest.mark.parametrize("dim", [1, 2, 3, 4]) | ||
| @pytest.mark.parametrize("method", ["linear", "nearest"]) | ||
| class TestInterpn: |
There was a problem hiding this comment.
What do these test classes do? want to learn 😆
| @@ -1014,8 +1014,8 @@ def insert_value(x, path: tuple[str, ...], sub_dict: dict): | |||
| sub_element = current_dict[final_key] | |||
| if isinstance(sub_element, DataArray): | |||
| current_dict[final_key] = sub_element.copy(deep=False, data=x) | |||
| if "AUTOGRAD" in sub_element.attrs: | |||
| current_dict[final_key].attrs["AUTOGRAD"] = x | |||
| if AUTOGRAD_KEY in sub_element.attrs: | |||
| vals = interpn(points, obj.tracers, xi, method=method) | ||
|
|
||
| da = DataArray(vals, dict(obj.coords) | coords) # tracers go into .attrs | ||
| if isbox(self.values.flat[0]): # if tracing .values instead of .attrs |
There was a problem hiding this comment.
or da.contains_tracers? although this seems to no longer exist?
There was a problem hiding this comment.
maybe it's fine for now until we standardize all of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements differentiable interpolation methods for
DataArray.plugins/autograd/functions.py.td.DataArray.DataArrayimplementation.