Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency conversion utility function #1783

Conversation

AndrewSykes1
Copy link

Adds feature described #1746

@tylerflex
Copy link
Collaborator

tylerflex commented Jun 26, 2024

Thanks @AndrewSykes1 ! We appreciate the contribution. After some internal discussion (which we should have updated in the original issue..). We think it would be better to have this function named wvl_to_freq so it's more explicit and there's less chance of confusion as to what it does.

Also, adding a changelog item under added would be useful to alert users to this (eg. `

- Convenience function for converting from wavelength (um) to frequency (Hz) using `td.wvl_to_freq(wvl)`

If you want, I can pick up this PR and make the changes, or you could modify it if you have time. Up to you.

Thanks again!

@AndrewSykes1
Copy link
Author

Sounds good, I'll have time to make the changes so should be no problem. Thanks for the correction!

@AndrewSykes1 AndrewSykes1 closed this by deleting the head repository Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants