Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed no sources in simulation log info. #1784

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Removed no sources in simulation log info. #1784

merged 1 commit into from
Jun 27, 2024

Conversation

e-g-melo
Copy link
Collaborator

The "No sources in simulation" log info was commented out to avoid showing this message in GUI.

image

@e-g-melo
Copy link
Collaborator Author

Actually, I will resubmit this following these instructions (https://docs.flexcompute.com/projects/tidy3d/en/latest/development/index.html).

@e-g-melo
Copy link
Collaborator Author

Hi! I am getting this error after commenting out that info log:
image

Should I remove this?
image

momchil-flex
momchil-flex approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, we can just squash and merge but I think we should add the invdes_history.json file to gitignore and remove from this PR. Tyler and I could do it once he confirms.

tests/data/invdes_history.json Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylerflex should we add this to gitignore?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

tylerflex
tylerflex approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @e-g-melo The PR looks ok to me. Could you file an issue (if not already) so we can make sure to fix this in the long term? Not sure who to assign at this point.

@momchil-flex momchil-flex merged commit 25a0ad3 into develop Jun 27, 2024
16 checks passed
@momchil-flex momchil-flex deleted the emerson/info_no_source branch June 27, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momchil-flex momchil-flex momchil-flex approved these changes

@tylerflex tylerflex tylerflex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@e-g-melo @momchil-flex @tylerflex