Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webapi refactor #730

Merged
merged 20 commits into from
Mar 10, 2023
Merged

webapi refactor #730

merged 20 commits into from
Mar 10, 2023

Conversation

tylerflex
Copy link
Collaborator

@tylerflex tylerflex commented Feb 27, 2023 •
edited
Loading

To Do list

  • make run in practice from in WebApi.ipynb
  • Refactor callback / web upload / download
  • Address Lei's PR review comments on webapi refactor #665
    • remove AWS
    • Separate Env for mockttest
    • Initialize SimulationTask with init when possible to avoid extra requests
    • handle plain text http response?
    • "what the json parameter for http.get? pass the json as the body on get request?"
    • exclude any extra characters in task_name?
    • is my handling of SimulationTask() creation in the webapi functions ok?
    • dont error in tests if authentication not set up.
    • custom callback option in download and upload functions.
  • Add Code coverage using mock for
    • queue.py:run_async
    • code in containers.py
    • main.py
  • Clean up all docstrings
  • Add real_cost()
    • weabpi function
    • Job
    • Batch

Next time

@tylerflex tylerflex mentioned this pull request Feb 27, 2023
Closed
4 tasks
@tylerflex tylerflex self-assigned this Feb 27, 2023
@tylerflex tylerflex added refactor rc2 2nd pre-release labels Feb 27, 2023
@tylerflex tylerflex linked an issue Feb 27, 2023 that may be closed by this pull request
Web API refactor #544
Closed
@tylerflex tylerflex force-pushed the tyler/new_web_model branch 8 times, most recently from bde60f3 to 9127940 Compare February 28, 2023 21:41
@tylerflex tylerflex mentioned this pull request Mar 3, 2023
Closed
@tylerflex tylerflex force-pushed the tyler/new_web_model branch 2 times, most recently from 6a5e3e5 to ed77f48 Compare March 3, 2023 19:17
@tylerflex tylerflex changed the base branch from develop to pre/1.10.0 March 9, 2023 18:32
@tylerflex tylerflex removed the refactor label Mar 9, 2023
@tylerflex tylerflex merged commit 78a2821 into pre/1.10.0 Mar 10, 2023
@tylerflex tylerflex deleted the tyler/new_web_model branch March 10, 2023 20:10
@tylerflex tylerflex mentioned this pull request Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lei-flex lei-flex lei-flex approved these changes

@momchil-flex momchil-flex momchil-flex approved these changes

Assignees

@tylerflex tylerflex

Labels
rc2 2nd pre-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web API refactor
4 participants
@tylerflex @lei-flex @momchil-flex @an-li-the-dev