restrict number of adjoint input structures #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll test a bit when everything else is merged in and parallelization works, I'd think we can live with 1000. |
|
Yeah no it seems like we'd have to keep it lower for now. I'm thinking 400 so your notebook still works. |
momchil-flex
force-pushed
the
tyler/adjoint/restrict_input_structures
branch
from
d84fa3a
to
501420f
Compare
momchil-flex
force-pushed
the
tyler/adjoint/restrict_input_structures
branch
from
501420f
to
824c82b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feel free to change the number, as long as the Metalens Demo supports it. I think it's currently 18x18 = 324 for the symmetry expanded one and under 100 without symmetry. However, we construct the symmetry expanded one for plotting at the end.. (even though we dont run it). Not really sure how to approach this. maybe a pre-upload validator? Note, if we go this route, we'll need to somehow ensure that the Simulation.validate_pre_upload() is still called.