Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supports abort task #998

Merged
merged 2 commits into from
Jul 20, 2023
Merged

supports abort task #998

merged 2 commits into from
Jul 20, 2023

Conversation

magiWei
Copy link

@magiWei magiWei commented Jul 13, 2023

No description provided.

momchil-flex
momchil-flex approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@momchil-flex momchil-flex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are formatting issues again. Could you fix those before we merge?

tidy3d/web/simulation_task.py Outdated Show resolved Hide resolved
@magiWei magiWei force-pushed the qingeng/support-abort branch 3 times, most recently from 62a89d1 to 5aa49e9 Compare July 17, 2023 05:35
momchil-flex
momchil-flex reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if user aborts a task and it is not running, e.g. if they abort a "draft", or if they abort a "success" task? What happens if a user calls the "start" api on an aborted task?

Looks good overall! Could you add a line to the CHANGELOG?

tidy3d/web/webapi.py Show resolved Hide resolved
tidy3d/web/simulation_task.py Show resolved Hide resolved
@magiWei magiWei force-pushed the qingeng/support-abort branch 5 times, most recently from ca88ac0 to 79e0e16 Compare July 19, 2023 04:12
@momchil-flex momchil-flex changed the base branch from develop to pre/2.4 July 20, 2023 00:04
@momchil-flex momchil-flex merged commit 2dadc09 into pre/2.4 Jul 20, 2023
2 checks passed
@momchil-flex momchil-flex deleted the qingeng/support-abort branch July 20, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momchil-flex momchil-flex momchil-flex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magiWei @momchil-flex