Feature: isDate, isSymbol Verify Javascript dates & primitive Symbols #FewMoreGemToTheCrown #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rehman-00001
changed the title
isDate, isSymbol Verify Javascript dates & primitive Symbols #FewMoreGemToTheCrown
rehman-00001
changed the title
isDate, isSymbol Verify Javascript dates & primitive Symbols #FewMoreGemToTheCrown
|
@rehman-00001 This looks good. Just letting you know that I've been a bit busy lately but will soon merge and release this PR and the other PR you opened in react-socks. Thanks for everything you do. You are amazing. |
flexdinesh
requested changes
Sep 11, 2019
There was a problem hiding this comment.
@rehman-00001 Once the return value is changed from null to undefined we can merge and release this.
flexdinesh
approved these changes
Sep 13, 2019
|
Thanks @rehman-00001. Changes published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.