New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docker] - Refactor and automatic upload of containers to repo #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
If the bash scripts in docker/
continue to get more complicated, we should really consider porting them over to python. Just having argparse, etc. would probably already reduce the amount of code significantly, and remove a bunch of more complex and unusual bash features.
Co-authored-by: Colin Unger <lockshaw@lockshaw.net>
Co-authored-by: Colin Unger <lockshaw@lockshaw.net>
This reverts commit e2c0d82.
yes, good point. Perhaps we can switch to Python when adding the |
Description of changes:
This PR refactors the Docker containers, to make the builds more efficient, and enables the user to pass build configs through the use of environment variables (passing build configs to Docker got partially broken after #392 ). In addition, we add a mechanism to automatically publish the environment and flexflow containers to
ghrc.io
. The CUDA version of the uploaded docker image is compatible with any CUDA GPU architecture. This gives us several advantages:flexflow
docker image if they want to try flexflow under the default configsflexflow-environment
image to avoid having to re-install all FlexFlow dependencies in each testRelated Issues:
Linked Issues:
Issues closed by this PR:
Before merging: