Don't send a body for delete requests

flexirest · Aug 31, 2017 · c5ae379 · c5ae379
1 parent 7f902ab
commit c5ae379
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.4.5
+
+Bugfix:
+
+- DELETE requests shouldn't send a request body, the body semantics are undefined.
+
 ## 1.4.4
 
 Feature:

diff --git a/lib/flexirest/request.rb b/lib/flexirest/request.rb
@@ -344,7 +344,7 @@ def prepare_request_body(params = nil)
 
         headers["Accept"] ||= "application/vnd.api+json"
         JsonAPIProxy::Headers.save(headers)
-      elsif http_method == :get
+      elsif http_method == :get || http_method == :delete
         @body = ""
       elsif request_body_type == :form_encoded
         @body ||= (params || @post_params || {}).to_query

diff --git a/lib/flexirest/version.rb b/lib/flexirest/version.rb
@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.4.4"
+  VERSION = "1.4.5"
 end