Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not validate when method is delete #60

Merged
merged 4 commits into from
Apr 27, 2017
Merged

Conversation

kjavier
Copy link
Contributor

@kjavier kjavier commented Dec 8, 2016

No description provided.

@coveralls
Copy link

coveralls commented Dec 8, 2016

Coverage Status

Coverage decreased (-0.07%) to 99.045% when pulling 8b9bd91 on kjavier:master into e4681f6 on flexirest:master.

@andyjeffries
Copy link
Collaborator

I don't know why those two tests fail (Travis), but they don't on my branch. Can you have a look please and ensure the tests still pass and I'll merge this in. Thanks.

@kjavier
Copy link
Contributor Author

kjavier commented Dec 12, 2016

@andyjeffries It seems that the failed tests are not related to my commit. When i removed my changes from the file and ran rspec, I still had the same errors. In https://travis-ci.org/flexirest/flexirest/jobs/182210920, the errors are related to not raising TimeoutException.

@andyjeffries
Copy link
Collaborator

Weird, I try it here and they all pass... Even using the same seed. I'll have a theoretical look at the code, but can't reproduce it.

@andyjeffries
Copy link
Collaborator

andyjeffries commented Dec 20, 2016

I've tried a few times over the past week, I can't get it to fail locally and the normal master branch passes on Travis, so I'm at a bit of an impasse. Can you get them to fail locally your side?

@coveralls
Copy link

coveralls commented Feb 24, 2017

Coverage Status

Coverage increased (+0.001%) to 99.046% when pulling 0ae10a0 on kjavier:master into 523414d on flexirest:master.

@execjosh
Copy link
Contributor

I believe #65 might take care of the reason for the test failures.

@andyjeffries
Copy link
Collaborator

Can you rebase off master as #65 is merged now. Then if they all pass I can get this merged in. Thanks.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 98.999% when pulling d5b73dc on kjavier:master into 0a3d11d on flexirest:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 98.999% when pulling d5b73dc on kjavier:master into 0a3d11d on flexirest:master.

@coveralls
Copy link

coveralls commented Apr 26, 2017

Coverage Status

Coverage increased (+0.001%) to 98.999% when pulling d5b73dc on kjavier:master into 0a3d11d on flexirest:master.

@kjavier
Copy link
Contributor Author

kjavier commented Apr 26, 2017

All checks have passed now. thanks!

@andyjeffries andyjeffries merged commit d20180a into flexirest:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants