-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not validate when method is delete #60
Conversation
I don't know why those two tests fail (Travis), but they don't on my branch. Can you have a look please and ensure the tests still pass and I'll merge this in. Thanks. |
@andyjeffries It seems that the failed tests are not related to my commit. When i removed my changes from the file and ran rspec, I still had the same errors. In https://travis-ci.org/flexirest/flexirest/jobs/182210920, the errors are related to not raising TimeoutException. |
Weird, I try it here and they all pass... Even using the same seed. I'll have a theoretical look at the code, but can't reproduce it. |
I've tried a few times over the past week, I can't get it to fail locally and the normal master branch passes on Travis, so I'm at a bit of an impasse. Can you get them to fail locally your side? |
I believe #65 might take care of the reason for the test failures. |
Can you rebase off master as #65 is merged now. Then if they all pass I can get this merged in. Thanks. |
2 similar comments
All checks have passed now. thanks! |
No description provided.