Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created POC to validate that flexbench can be wrapped as a desktop app #21

Merged
merged 9 commits into from
Jul 18, 2022

Conversation

Kanha-13
Copy link

Pull request for #19

  • I have created POC using electron as a framework and using react as a component library.
  • I have tested the POC on windows as well as Linux. Woking fine.
  • I have not been able to test it on MacOs.

@iskitsas
Copy link

You should not change the basic folder structure and include everything under a POC folder. Instead, try to decouple the poc from the main library. For example leave the core library contents as they are, and create a separate poc folder, where you put everything needed in there (electron related etc). Then, your poc should relatively wrap the core library where needed

@Kanha-13
Copy link
Author

Ok I will change accordingly

@Kanha-13
Copy link
Author

I have made the required changes. Please review it once.

@ikyranas ikyranas merged commit bcf4059 into flexivian:develop Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants