Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexbench desktop app (MVP) #28

Merged
merged 44 commits into from
Aug 12, 2022
Merged

Conversation

Kanha-13
Copy link

@Kanha-13 Kanha-13 commented Jul 29, 2022

PR for the first MVP release
This pr include following issues and sub-issues:

  1. Create MVP standalone app
  2. Create a GUI using electron
  3. Basic requirements and UX for flexbench desktop app
  4. Basic layout: Top bar menu, left sidebar, main right panel, small bottom bar
  5. Top bar menu: Import | Export| create | Projects
  6. Sidebar component: create/configure collections and requests
  7. Main panel: set request data (support port, method, params)

Build Check:

  • Able to reproduce the project on local.
  • Able to create new project / scenario / request
  • Simple / multi request working correctly
  • Data persist
  • Able to import / export projects

@iskitsas
Copy link

iskitsas commented Aug 1, 2022

@Kanha-13 after building/installing it on a mac and playing with a simple request I get:

image

A JavaScript error occurred in the main process
Uncaught Exception:
Error: ENOENT: no such file or directory, open '/Users/iskitsas/Library/Preferences/flexbench_electron/Temp/configs.json'
at Object.openSync (node:fs:585:3)
at Object.func [as openSync] (node:electron/js2c/asar_bundle:5:1812)
at Object.readFileSync (node:fs:453:35)
at e.readFileSync (node:electron/js2c/asar_bundle:5:9160)
at runTest (/Applications/flexbench_electron.app/Contents/Resources/app.asar/tests/simple-request.js:10:27)
at Object.<anonymous> (/Applications/flexbench_electron.app/Contents/Resources/app.asar/tests/simple-request.js:66:1)
at Module._compile (node:internal/modules/cjs/loader:1118:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1173:10)
at Module.load (node:internal/modules/cjs/loader:988:32)
at Module._load (node:internal/modules/cjs/loader:829:12)

@iskitsas
Copy link

iskitsas commented Aug 1, 2022

The title of the app when installed should be Flexbench and not flexbench_electron. It would be nice to have another app image instead of the default electron logo

image

@Kanha-13
Copy link
Author

Kanha-13 commented Aug 2, 2022

Got it, I have encountered the same issue for Linux too. Actually it was due to hard-coded , dirr path. I will update the path for mac too. Thank you for the review.

@Kanha-13
Copy link
Author

Kanha-13 commented Aug 2, 2022

The title of the app when installed should be Flexbench and not flexbench_electron. It would be nice to have another app image instead of the default electron logo

image

Sure I will update these two changes.
You have any icon available or should I use the same icon of app's header logo!

@iskitsas
Copy link

iskitsas commented Aug 2, 2022

@Kanha-13 , I still get a similar error when clicking the RUN configuration:

image

@iskitsas
Copy link

iskitsas commented Aug 2, 2022

After playing around and pushing to more requests, I was able to get this error:
image

Uncaught Exception:
Error: write EPIPE
at target._send (node:internal/child_process:866:20)
at target.send (node:internal/child_process:739:19)
at Worker.send (node:internal/cluster/worker:46:10)
at /Applications/Flexbench.app/Contents/Resources/app.asar/lib/main.js:128:20
at eachWorker (/Applications/Flexbench.app/Contents/Resources/app.asar/lib/main.js:115:13)
at Object.stop (/Applications/Flexbench.app/Contents/Resources/app.asar/lib/main.js:126:9)
at Timeout._onTimeout (/Applications/Flexbench.app/Contents/Resources/app.asar/tests/simple-request.js:31:26)
at listOnTimeout (node:internal/timers:559:17)
at process.processTimers (node:internal/timers:502:7) 

@Kanha-13
Copy link
Author

Kanha-13 commented Aug 3, 2022

@Kanha-13 , I still get a similar error when clicking the RUN configuration:

image

is single request working?

@Kanha-13
Copy link
Author

Kanha-13 commented Aug 3, 2022

I think the second bug is because of #27 this issue

@iskitsas iskitsas changed the title Code review Flexbench desktop app (MVP) Aug 3, 2022
@iskitsas
Copy link

@Kanha-13 can you resolve the conflicts?

@Kanha-13
Copy link
Author

Ok I will push the updates

@Kanha-13
Copy link
Author

Kanha-13 commented Aug 11, 2022

@iskitsas could you please check now, I guess it's now resolved!

@iskitsas iskitsas merged commit 324c7a7 into flexivian:develop Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants