Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for missing body data in request #30

Merged
merged 8 commits into from
Aug 11, 2022
Merged

Conversation

Kanha-13
Copy link

@Kanha-13 Kanha-13 commented Jul 31, 2022

PR for #29 and #27 and #13

Fix for #29

  • In this fix, body data is nowgetting received by the endpoint.
  • And I have also updated the example of fileupload.js for POST request.

Fix for #27

  • Using worker.process.pid as port number for proxy server to resolve the conflict of port number already occupied or busy error

Files modified:

  1. main.js
  2. fileupload.js

Note: But this fix is not working when **throttling for #29 **

@iskitsas
Copy link

iskitsas commented Aug 1, 2022

@Kanha-13 you should checkout from develop and target the develop branch for this fix

@Kanha-13
Copy link
Author

Kanha-13 commented Aug 2, 2022

Ok, I will change the target branch.

@Kanha-13
Copy link
Author

Kanha-13 commented Aug 3, 2022

@iskitsas This fix is for main lib only and develop branch has the codes of desktop-app also!
So should I target develop ?

@iskitsas
Copy link

iskitsas commented Aug 3, 2022

@Kanha-13 it is ok to target this fix towards develop branch. The next release we will do will also include your MVP ;)

@Kanha-13 Kanha-13 changed the base branch from master to develop August 10, 2022 15:11
@Kanha-13
Copy link
Author

@iskitsas I have changed the target branch

@Kanha-13
Copy link
Author

I have also pushed the fix for #27 in this pr.

@iskitsas iskitsas merged commit 9c99177 into flexivian:develop Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants