Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR includes major fix for desktop app #41

Merged
merged 9 commits into from
Sep 15, 2022

Conversation

Kanha-13
Copy link

@Kanha-13 Kanha-13 commented Sep 7, 2022

This PR includes a bug fix for desktop-app.

Note:

Fix for #40 modifies the `lib/main.js`
Changes: In the `function start()` added a parameter `threadId`

Reason: child process forked by cluster required the thread id of its parent thread, for getting the config stored in a file which is 
named as `process.pid+threadId`

Why this kind of file name: because there was a need to make filename unique for every request fit from the UI, there fore this 
was the only way I could think of to make it unique and using any other approach was not able to pass the file name to the 
forked processes

@iskitsas iskitsas merged commit 8dd0727 into flexivian:develop Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants