Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements (re-enable lints, update deps, add py.typed file) #125

Merged
merged 4 commits into from Jan 12, 2022
Merged

Small improvements (re-enable lints, update deps, add py.typed file) #125

merged 4 commits into from Jan 12, 2022

Conversation

ollipa
Copy link
Member

@ollipa ollipa commented Jan 12, 2022 •
edited

  • Re-enable some pylint lint rules
  • Update dependencies
  • Add PEP 561 py.typed marker file
  • Test that Mkdocs build completes without errors in CI

@ollipa ollipa self-assigned this Jan 12, 2022
@ollipa ollipa mentioned this pull request Jan 12, 2022
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022 •
edited

Codecov Report

Merging #125 (06c1053) into master (54401b5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          833       833           
=========================================
  Hits           833       833
Impacted Files Coverage Δ
src/flexmock/_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54401b5...06c1053. Read the comment docs.

christophe-riolo
christophe-riolo approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@christophe-riolo christophe-riolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward changes 👍

@ollipa ollipa merged commit 31091e7 into master Jan 12, 2022
@ollipa ollipa deleted the chore/enable-some-lints branch January 12, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophe-riolo christophe-riolo christophe-riolo approved these changes

@adarshk7 adarshk7 Awaiting requested review from adarshk7

Assignees

@ollipa ollipa

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ollipa @codecov-commenter @christophe-riolo