Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox.ini to sdist #137

Merged
merged 1 commit into from Mar 5, 2023
Merged

Add tox.ini to sdist #137

merged 1 commit into from Mar 5, 2023

Conversation

ollipa
Copy link
Member

@ollipa ollipa commented Nov 27, 2022

Add tox.ini to sdist to make the downstream testing easier. Closes #136.

@ollipa ollipa added the build label Nov 27, 2022
@ollipa ollipa self-assigned this Nov 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Merging #137 (a1341a5) into master (86f2d36) will not change coverage.
The diff coverage is n/a.

❗ Current head a1341a5 differs from pull request most recent head 1b1d761. Consider uploading reports for the commit 1b1d761 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##            master      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          833       833           
=========================================
  Hits           833       833           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@christophe-riolo
Copy link
Contributor

christophe-riolo commented Dec 8, 2022

I am not sure how this downstream testing is performed, I'd like to test it, do you have any idea ?

@christophe-riolo
Copy link
Contributor

I am not sure how this downstream testing is performed, I'd like to test it, do you have any idea ?

Do you know about this @ollipa ?

@ollipa
Copy link
Member Author

ollipa commented Jan 4, 2023

@christophe-riolo, sorry I just noticed your response. It seems that Github sometimes misses email notifications.

To test this, I think you can run poetry build and then extract the created tar.gz file somewhere and then try run tests with tox.

Copy link
Contributor

@christophe-riolo christophe-riolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally took time to test this properly, the tox file is properly included when running poetry build 👍

Add tox.ini to sdist to make the downstream testing easier.
Closes #136.
@ollipa ollipa merged commit 5da4e4d into master Mar 5, 2023
@ollipa ollipa deleted the chore/tox-xdist branch March 5, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sdist is missing tox.ini
3 participants