Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fix scrollview in modern RN #121

Merged
merged 5 commits into from Jul 13, 2023
Merged

Conversation

aurimasmi
Copy link
Contributor

@aurimasmi aurimasmi commented Jul 7, 2023

Ticket: #112

How to test:
Same instructions as #111
Difference is between version right version to use is: 1.0.0-featrnsupport.5

@aurimasmi aurimasmi marked this pull request as ready for review July 10, 2023 12:10
@aurimasmi aurimasmi added this to the 1.0 milestone Jul 10, 2023
Copy link
Contributor

@RicardasN RicardasN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-07-12 at 16 26 20
Got this error following the provided testing steps. Adding "@flexn/shopify-flash-list": "1.4.8" solved said issue, but perhaps it should've been in a peer dependency?

Other than that everything works on both AndroidTV and AppleTV
Screenshot 2023-07-12 at 16 33 25

@aurimasmi
Copy link
Contributor Author

#111

Yes it's is peerDependency and in documentantion I've added this as an installation step

@aurimasmi aurimasmi merged commit 9e8304e into main Jul 13, 2023
1 check passed
@aurimasmi aurimasmi deleted the feat/modern-rn-scroll-support branch August 23, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants