Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webtvs implementation for template #138

Merged
merged 2 commits into from Jul 20, 2023
Merged

Conversation

aurimasmi
Copy link
Contributor

Added support for web tvs for template. It has be tested in hosted mode by running:

npx rnv run -p tizen --hosted or npx rnv run -p webos --hosted

Also fixed potential issue when component is removed before it's measured and that will cause focus manager being in halt

Copy link
Contributor

@RicardasN RicardasN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-07-20 at 11 59 23
Can't seem to run template starter (nor the app nor the template config works for me), but the code looks good.

@@ -99,6 +103,7 @@ const styles = StyleSheet.create({
zIndex: 2,
opacity: 1,
position: 'absolute',
...((isPlatformTizen || isPlatformWebos) && { height: height }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
...((isPlatformTizen || isPlatformWebos) && { height: height }),
...((isPlatformTizen || isPlatformWebos) && { height }),

@aurimasmi aurimasmi merged commit 34b60a6 into release/1.0 Jul 20, 2023
1 check passed
@aurimasmi aurimasmi deleted the feat/template-webtv branch August 23, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants