New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix postinstall script on linux #146

Merged

mihaiblaga89 merged 2 commits into release/1.0 from fix/postinstall_script_crossplatform

Jul 31, 2023

Member

mihaiblaga89 commented Jul 31, 2023

calling it with sh means it's using shell and ignoring the bash shebang from the top of the file. -o pipefail is a bash feature.
#!/usr/bin/env bash is preffered instead of #!/bin/bash

mihaiblaga89 added 2 commits

July 31, 2023 18:12


          fix shell script on ubuntu

01de2d2


          removed debugging log

d71bd63

mihaiblaga89 marked this pull request as ready for review

July 31, 2023 15:16

mihaiblaga89 merged commit c5040fe into release/1.0

1 check passed

mihaiblaga89 mentioned this pull request

Cross platform postinstall #147

Closed

aurimasmi deleted the fix/postinstall_script_crossplatform branch

August 23, 2023 06:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment