Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assetsSources (alternative source path for rnv app assets) #1005

Merged
merged 1 commit into from Jun 15, 2023

Conversation

pavjacko
Copy link
Member

Description

  • Array of paths to alternative external assets. this will take priority over ./appConfigs/base/assets folder on your local project

Breaking Changes

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@pavjacko pavjacko self-assigned this Jun 15, 2023
@pavjacko pavjacko merged commit a37ac19 into canary Jun 15, 2023
1 check failed
@pavjacko pavjacko deleted the feat/assets-sources branch June 15, 2023 20:20
@mihaiblaga89 mihaiblaga89 added this to the 0.37 milestone Jun 19, 2023
@GabrieleKaceviciute
Copy link
Collaborator

@pavjacko How should I test it?

@mihaiblaga89
Copy link
Member

@GabrieleKaceviciute can be considered ready for release. The feature is already present in the template and the fact that we have icons is proof that it's working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants