Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rawLog json support #1034

Merged
merged 1 commit into from Jun 21, 2023
Merged

rawLog json support #1034

merged 1 commit into from Jun 21, 2023

Conversation

mihaiblaga89
Copy link
Member

@mihaiblaga89 mihaiblaga89 commented Jun 21, 2023

Description

add rawLog json support

Testcase

every rnv command with --json should only spit out JSON lines

@mihaiblaga89 mihaiblaga89 self-assigned this Jun 21, 2023
@pavjacko pavjacko added this to the 0.37 milestone Jun 21, 2023
@pavjacko pavjacko merged commit e277bdc into release/0.37 Jun 21, 2023
1 check failed
@pavjacko pavjacko deleted the fix/raw_log_json branch June 21, 2023 23:19
@pauliusguzas
Copy link
Collaborator

pauliusguzas@Pauliuss-MBP gab4 % rnv run -p web --json
{"type":"task","task":"","message":"registerEngine:engine-core"}
{"type":"task","task":"","message":"appId:null"}
{"type":"task","task":"","message":"checkAndMigrateProject"}
{"type":"task","task":"","message":"loadPluginTemplates"}
{"type":"task","task":"","message":"scope:root"}
{"type":"task","task":"","message":"parseRenativeConfigs"}
{"type":"task","task":"","message":"getWorkspaceDirPath"}
{"type":"task","task":"","message":"_generatePlatformTemplatePaths"}
{"type":"task","task":"","message":"checkAndBootstrapIfRequired"}
{"type":"task","task":"","message":"loadIntegrations"}
{"type":"task","task":"","message":"loadEngines"}
{"type":"task","task":"","message":"loadEnginePluginDeps"}
{"type":"task","task":"","message":"loadEnginePackageDeps"}
{"type":"task","task":"","message":"registerEngine:engine-rn-next"}
{"type":"task","task":"","message":"findSuitableTask"}
{"type":"log","level":"info","task":"","message":"Current Engine: engine-rn-next path: ./node_modules/@rnv/engine-rn-next"}
{"type":"task","task":"","message":"registerMissingPlatformEngines"}
{"type":"task","task":"","message":"run"}
{"type":"taskInit","task":"run","message":"=> [run]"}
{"type":"task","task":"run","message":"checkIfProjectAndNodeModulesExists"}
{"type":"hook","hook":"executePipe","message":"run:before","task":"run"}
{"type":"hook","hook":"buildHooks","message":"Build hooks not complied. BUILDING...","task":"run"}
 > tsconfig.json:2:15: warning: Cannot find base config file "@flexn/typescript/tsconfig.app.json"
    2 │     "extends": "@flexn/typescript/tsconfig.app.json",
      ╵                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[ task ] [run] taskRnvRun[1] parent:null
{"type":"taskInit","task":"configure","message":"=> [run] => [configure]"}
{"type":"hook","hook":"executePipe","message":"configure:before","task":"configure"}
{"type":"task","task":"configure","message":"taskRnvConfigure"}
{"type":"taskInit","task":"platform configure","message":"=> [configure] => [platform configure]"}
{"type":"hook","hook":"executePipe","message":"platform:configure:before","task":"platform configure"}
{"type":"task","task":"platform configure","message":""}
{"type":"taskInit","task":"project configure","message":"=> [platform configure] => [project configure]"}
{"type":"hook","hook":"executePipe","message":"project:configure:before","task":"project configure"}
{"type":"task","task":"project configure","message":"taskRnvProjectConfigure"}
{"type":"task","task":"project configure","message":"checkAndMigrateProject"}
{"type":"task","task":"project configure","message":"loadPluginTemplates"}
{"type":"task","task":"project configure","message":"scope:root"}
{"type":"task","task":"project configure","message":"parseRenativeConfigs"}
{"type":"task","task":"project configure","message":"getWorkspaceDirPath"}
{"type":"task","task":"project configure","message":"_generatePlatformTemplatePaths"}
{"type":"taskInit","task":"workspace configure","message":"=> [project configure] => [workspace configure]"}
{"type":"task","task":"workspace configure","message":"taskRnvWorkspaceConfigure"}
{"type":"taskExit","task":"project configure","message":"<= [project configure] <= workspace configure"}
{"type":"task","task":"project configure","message":"checkIfTemplateConfigured"}
{"type":"taskInit","task":"install","message":"=> [project configure] => [install]"}
{"type":"hook","hook":"executePipe","message":"install:before","task":"install"}
{"type":"task","task":"install","message":"requiresInstall:false:true"}
{"type":"hook","hook":"executePipe","message":"install:after","task":"install"}
{"type":"taskExit","task":"project configure","message":"<= [project configure] <= install"}
{"type":"task","task":"project configure","message":"checkCrypto"}
{"type":"task","task":"project configure","message":"appId:app"}
{"type":"task","task":"project configure","message":"@rnv/template-starter=>undefined"}
{"type":"task","task":"project configure","message":"current:@rnv/template-starter selected:undefined"}
{"type":"task","task":"project configure","message":"appId:app"}
{"type":"taskInit","task":"install","message":"=> [project configure] => [install]"}
{"type":"hook","hook":"executePipe","message":"install:before","task":"install"}
{"type":"task","task":"install","message":"requiresInstall:false:true"}
{"type":"hook","hook":"executePipe","message":"install:after","task":"install"}
{"type":"taskExit","task":"project configure","message":"<= [project configure] <= install"}
{"type":"taskInit","task":"app configure","message":"=> [project configure] => [app configure]"}
{"type":"hook","hook":"executePipe","message":"app:configure:before","task":"app configure"}
{"type":"task","task":"app configure","message":"taskRnvAppConfigure"}
{"type":"task","task":"app configure","message":"ignoreHiddenConfigs:true"}
{"type":"task","task":"app configure","message":"loadPluginTemplates"}
{"type":"task","task":"app configure","message":"scope:root"}
{"type":"task","task":"app configure","message":"parseRenativeConfigs"}
{"type":"task","task":"app configure","message":"size:193.92 KB"}
{"type":"task","task":"app configure","message":"getWorkspaceDirPath"}
{"type":"task","task":"app configure","message":"size:193.92 KB"}
{"type":"task","task":"app configure","message":"size:193.92 KB"}
{"type":"task","task":"app configure","message":"size:193.92 KB"}
{"type":"task","task":"app configure","message":"_generatePlatformTemplatePaths"}
{"type":"task","task":"app configure","message":"size:206.89 KB"}
{"type":"task","task":"app configure","message":"size:206.89 KB"}
{"type":"task","task":"app configure","message":"getWorkspaceDirPath"}
{"type":"task","task":"app configure","message":"size:206.89 KB"}
{"type":"task","task":"app configure","message":"resetAppId:false"}
{"type":"task","task":"app configure","message":"size:206.89 KB"}
{"type":"hook","hook":"executePipe","message":"app:configure:after","task":"app configure"}
{"type":"taskExit","task":"project configure","message":"<= [project configure] <= app configure"}
{"type":"task","task":"project configure","message":"versionCheck"}
{"type":"task","task":"project configure","message":"versionCheck:rnvRunner:0.37.0-rc.9,rnvProject:0.37.0-rc.9"}
{"type":"task","task":"project configure","message":"configureEngines"}
{"type":"task","task":"project configure","message":"resolvePluginDependants"}
{"type":"task","task":"project configure","message":"configurePlugins"}
{"type":"task","task":"project configure","message":"appId:app"}
{"type":"task","task":"project configure","message":"copyRuntimeAssets"}
{"type":"task","task":"project configure","message":"configureTemplateFiles"}
{"type":"task","task":"project configure","message":"checkAndCreateGitignore"}
{"type":"task","task":"project configure","message":"checkAndCreateBabelConfig"}
{"type":"task","task":"project configure","message":"generateRuntimeConfig"}
{"type":"task","task":"project configure","message":"overrideTemplatePlugins"}
{"type":"task","task":"project configure","message":"parsePlugins"}
{"type":"log","level":"info","task":"project configure","message":"/react-native overriden by: /@flexn/plugins/pluginTemplates/react-native/overrides@0.67.2"}
{"type":"log","level":"info","task":"project configure","message":"/next/dist/lib/find-pages-dir.js overriden by: /@flexn/plugins/pluginTemplates/next/overrides.json"}
{"type":"log","level":"info","task":"project configure","message":"/@react-native-community/cli-platform-ios overriden by: /@flexn/plugins/pluginTemplates/@react-native-community/cli-platform-ios/overrides"}
{"type":"log","level":"info","task":"project configure","message":"/react-native-gesture-handler overriden by: /@flexn/plugins/pluginTemplates/react-native-gesture-handler/overrides"}
{"type":"log","level":"info","task":"project configure","message":"/react-native-tvos overriden by: /@flexn/plugins/pluginTemplates/react-native-tvos/overrides@0.66.3-1"}
{"type":"task","task":"project configure","message":"parseFonts"}
{"type":"task","task":"project configure","message":"parsePlugins"}
{"type":"hook","hook":"executePipe","message":"project:configure:after","task":"project configure"}
{"type":"taskExit","task":"platform configure","message":"<= [platform configure] <= project configure"}
{"type":"task","task":"platform configure","message":"isPlatformSupported"}
{"type":"task","task":"platform configure","message":"checkAndConfigureSdks"}
{"type":"task","task":"platform configure","message":"isBuildSchemeSupported"}
{"type":"log","level":"info","task":"platform configure","message":"Current Build Scheme: debug"}
{"type":"task","task":"platform configure","message":"checkSdk"}
{"type":"task","task":"platform configure","message":"_isSdkInstalled"}
{"type":"task","task":"platform configure","message":"(/Users/pauliusguzas/Library/Android/sdk)"}
{"type":"task","task":"platform configure","message":"appId:app"}
{"type":"taskInit","task":"install","message":"=> [platform configure] => [install]"}
{"type":"hook","hook":"executePipe","message":"install:before","task":"install"}
{"type":"task","task":"install","message":"requiresInstall:false:true"}
{"type":"hook","hook":"executePipe","message":"install:after","task":"install"}
{"type":"taskExit","task":"platform configure","message":"<= [platform configure] <= install"}
{"type":"task","task":"platform configure","message":"taskRnvPlatformConfigure hasBuildFolderPresent:true"}
{"type":"task","task":"platform configure","message":"createPlatformBuild"}
{"type":"task","task":"platform configure","message":"injectPlatformDependencies"}
{"type":"hook","hook":"executePipe","message":"platform:configure:after","task":"platform configure"}
{"type":"taskExit","task":"configure","message":"<= [configure] <= platform configure"}
{"type":"task","task":"configure","message":"configureNextIfRequired"}
{"type":"task","task":"configure","message":"copyAssetsFolder"}
{"type":"log","level":"warning","task":"configure","message":"Your app is missing assets at ./appConfigs/base,./appConfigs/app."}
{"type":"hook","hook":"executePipe","message":"configure:after","task":"configure"}
{"type":"taskExit","task":"run","message":"<= [run] <= configure"}
{"type":"task","task":"run","message":"port:8080"}
{"type":"log","level":"info","task":"run","message":"Your web devServerHost 0.0.0.0 at port 8080 is not running. Starting it up for you..."}
{"type":"task","task":"run","message":"ip:0.0.0.0 port:8080 openBrowser:true"}
{"type":"task","task":"run","message":"port:8080"}
┌──────────────────────────────────────────────────────────────────────────────┐
│  🚀  BUNDLER STARTED | 7/10/2023, 10:56:32 AM                                │
│  $ rnv run -p web --json                                                     │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: undefined                                                 │
│  Project Name ($package.name): gab4                                          │
│  Project Version ($package.version): 0.1.0                                   │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): web                                                          │
│  Engine ($.platforms.web.engine): engine-rn-next                             │
│  Template: @rnv/template-starter@0.37.0-rc.9                                 │
│  App Config (-c): app                                                        │
│  Build Scheme (-s): debug                                                    │
web│  Env Info: darwin | x64 | node v16.14.2                                      │
│  Executed Time: 0h:0m:2s:883ms                                               │
│                                                                              │
│  All good as 🦄                                                              │
│                                                                              │
│  Project location:                                                           │
│  ./platformBuilds/app_web                                                    │
└──────────────────────────────────────────────────────────────────────────────┘
{"type":"task","task":"run","message":"runWebDevServer"}
{"type":"rawLog","task":"run","message":"[\"\\n\\nDev server running at: http://0.0.0.0:8080\\n\\n\"]"}
{"type":"task","task":"run","message":"parsePlugins"}
{"type":"task","task":"run","message":"parsePlugins"}
{"type":"rawLog","task":"run","message":"[\"✔ Executing: npx next dev --port 8080\\n\"]"}
ready - started server on 0.0.0.0:8080, url: http://localhost:8080
Found custom dir:/Users/pauliusguzas/Desktop/gab4/src/pages
error TS6053: File '@flexn/typescript/tsconfig.app.json' not found.

{"type":"log","level":"error","task":"run","message":"COMMAND: \n\nnpx next dev --port 8080 \n\nFAILED with ERROR: \n\nCommand failed with exit code 1: npx next dev --port 8080\n\nError: Command failed with exit code 1: npx next dev --port 8080\n    at makeError (./node_modules/execa/lib/error.js:60:11)\n    at handlePromise (./node_modules/execa/index.js:118:26)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)\n\n"}
pauliusguzas@Pauliuss-MBP gab4 %

@mihaiblaga89 is this acceptable as there are non json formatted logs?

@mihaiblaga89
Copy link
Member Author

nope, moving to failed qa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants