Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change release scheme name #1091

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: change release scheme name #1091

merged 1 commit into from
Oct 3, 2023

Conversation

pauliusguzas
Copy link
Collaborator

Description

  • Describe the nature of the work / fix

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@pauliusguzas pauliusguzas linked an issue Aug 28, 2023 that may be closed by this pull request
Cannot build release for android in 0.37.1 #1086
Closed
@pauliusguzas pauliusguzas mentioned this pull request Aug 28, 2023
Closed
@pauliusguzas pauliusguzas added this to the 0.37 milestone Aug 28, 2023
@mihaiblaga89 mihaiblaga89 self-assigned this Aug 29, 2023
@pavjacko pavjacko merged commit 8194033 into main Oct 3, 2023
3 checks passed
@pavjacko pavjacko deleted the fix/template-starter-release-scheme-name branch October 3, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavjacko pavjacko pavjacko approved these changes

@mihaiblaga89 mihaiblaga89 mihaiblaga89 approved these changes

Assignees

@mihaiblaga89 mihaiblaga89

Labels
None yet
Projects
None yet
Milestone
0.37
Development

Successfully merging this pull request may close these issues.

Cannot build release for android in 0.37.1
3 participants
@pauliusguzas @pavjacko @mihaiblaga89