Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Device Management #1269

Merged
merged 11 commits into from Dec 7, 2023
Merged

iOS Device Management #1269

merged 11 commits into from Dec 7, 2023

Conversation

mihaiblaga89
Copy link
Member

Description

  • move from xcrun to appium-ios-device

Related issues

Npm releases

n/a

@GabrieleKaceviciute
Copy link
Collaborator

  1. npx rnv run -p ios
TypeError: appium_ios_device_1.utilities.getDeviceInfo is not a function
    at /Users/gabriele/Desktop/renative/packages/sdk-apple/src/deviceManager.ts:29:38
    at step (/Users/gabriele/Desktop/renative/node_modules/tslib/tslib.js:195:27)
    at Object.next (/Users/gabriele/Desktop/renative/node_modules/tslib/tslib.js:176:57)
    at /Users/gabriele/Desktop/renative/node_modules/tslib/tslib.js:169:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/Users/gabriele/Desktop/renative/node_modules/tslib/tslib.js:165:16)
    at /Users/gabriele/Desktop/renative/packages/sdk-apple/src/deviceManager.ts:28:94
    at Array.map (<anonymous>)
    at /Users/gabriele/Desktop/renative/packages/sdk-apple/src/deviceManager.ts:28:73
    at step (/Users/gabriele/Desktop/renative/node_modules/tslib/tslib.js:195:27)
    at Object.next (/Users/gabriele/Desktop/renative/node_modules/tslib/tslib.js:176:57)
    at fulfilled (/Users/gabriele/Desktop/renative/node_modules/tslib/tslib.js:166:62)

 $ npx rnv run -p ios - Done! 🚀
┌──────────────────────────────────────────────────────────────────────────────┐
│  🚀  SUMMARY | 12/5/2023, 4:56:34 PM                                         │
│  $ npx rnv run -p ios                                                        │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: 1.0.0-rc.1                                                │
│  Project Name ($package.name): @rnv/template-starter                         │
│  Project Version ($package.version): 1.0.0-rc.1                              │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): ios                                                          │
│  Engine ($.platforms.ios.engine): engine-rn                                  │
│  App Config (-c): template                                                   │
│  Build Scheme (-s): debug                                                    │
│  Target (-t): iPhone 14                                                      │
│  Supported Platforms: ios                                                    │
│  Env Info: darwin | x64 | node v18.14.2                                      │
│  Executed Time: 0h:0m:1s:53ms                                                │
│                                                                              │
│  All good as 🦄                                                              │
│                                                                              │
│  Project location:                                                           │
│  ./platformBuilds/template_ios/RNVApp.xcworkspace                            │
└──────────────────────────────────────────────────────────────────────────────┘
➜  ~/Desktop/renative/packages/template-starter git:(fix/ios_dev_management) ✗

@mihaiblaga89 mihaiblaga89 marked this pull request as ready for review December 5, 2023 21:29
@pavjacko
Copy link
Member

pavjacko commented Dec 5, 2023

@GabrieleKaceviciute can you re-test now

@pavjacko pavjacko added this to the 1.0 milestone Dec 6, 2023
@pauliusguzas
Copy link
Collaborator

pauliusguzas commented Dec 7, 2023

Have device connected and:

  • -p ios -t -> only sims are shown, devices should be too
  • -p ios -d -> bundler doesn't start
  • -p ios -d -t -> doesn't ask from list, bundler doesn't start
  • -p ios -t device-name -> We couldn't find iPad as a device supported by the current version of your Xcode.
  • -p ios -d -t device-name -> bundler doesn't start

@pauliusguzas
Copy link
Collaborator

  • -p ios -t -> shows ipad as phone
  • -p ios -d -> installed to sim, not device
  • -p ios -d -t -> shows devices and sims, should show devices
  • -p ios -t device-name -> starts on simulator
  • -p ios -d -t device-name -> need to click reload JS after app is launched on device

@pavjacko pavjacko merged commit 73e34b6 into release/1.0 Dec 7, 2023
2 checks passed
@pavjacko pavjacko deleted the fix/ios_dev_management branch December 7, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants