Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rnv standalone command fixes #1392

Merged
merged 14 commits into from Feb 14, 2024
Merged

rnv standalone command fixes #1392

merged 14 commits into from Feb 14, 2024

Conversation

pavjacko
Copy link
Member

Description

  • When running rnv through wizard, all commands and sub-commands should trigger properly

Related issues

Npm releases

n/a

…x/rnv_target

* 'fix/rnv_target' of github.com:flexn-io/renative:
  add handling for tizen already running
  unionize CLI calling for tizen, proper handle of error
  test
  ask where to run if tizen target launch and none selected
  added rn_modules exclusion for template-starter
  update next, set node_env to prod, exclude rn_modules from ts
  added required env variables to xcodebuild
  remove hardcoded packageID
  remove assetSources for ios
  remove no-packager from android build
  rename test module
  allow androidtv backup
  proper injections, add back hermes config
  prefixed HERMES_ENABLED and PLUGIN_DEPLOYMENT_TARGET with INJECT
* release/1.0:
  fix: cli target launch webos
  fix target list webos
@pavjacko pavjacko changed the base branch from main to release/1.0 February 12, 2024 18:00
@pavjacko pavjacko added this to the 1.0 milestone Feb 12, 2024
@pavjacko pavjacko marked this pull request as draft February 12, 2024 18:03
@pavjacko pavjacko marked this pull request as ready for review February 12, 2024 20:52
* release/1.0:
  change android selector
  small fix
  small fix
  change run ios logs
  remove_question_when_run_decrypt_for_the_first_time
  change logs text
  change android selector text

# Conflicts:
#	packages/engine-core/src/tasks/task.rnv.target.launch.ts
#	packages/engine-core/src/tasks/task.rnv.target.list.ts
* release/1.0:
  fix warning message
  fix result for wrong target
  commented out UT
  rename function
  add error when target is specified but not available
  fix target when target is not active
  android -> -t do not ask to select device/simulator when needed
@pauliusguzas pauliusguzas self-requested a review February 14, 2024 07:59
@mihaiblaga89 mihaiblaga89 merged commit 162fc66 into release/1.0 Feb 14, 2024
1 check passed
@pavjacko pavjacko deleted the fix/rnv_command branch February 14, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants