Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npx build for webos/tizen shouldn't build without an emulator downloaded #1592

Merged
merged 7 commits into from
Jun 19, 2024

Conversation

justinasRm
Copy link
Contributor

Description

  • When doing npx rnv build for webos and tizen, the check for sdk happens earlier and stops the building process if it doesn't exist.

Related issues

Npm releases

n/a

@justinasRm justinasRm added this to the 1.0 milestone Jun 3, 2024
@justinasRm justinasRm self-assigned this Jun 3, 2024
@justinasRm justinasRm marked this pull request as draft June 3, 2024 07:14
@justinasRm justinasRm requested a review from pavjacko June 4, 2024 08:22
@justinasRm justinasRm marked this pull request as ready for review June 4, 2024 08:22
@justinasRm justinasRm added e2e and removed e2e labels Jun 4, 2024
@pauliusguzas pauliusguzas added e2e and removed e2e labels Jun 6, 2024
]
],
"dependencies": {
"raf": "3.4.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to devDeps

@justinasRm justinasRm requested a review from pavjacko June 12, 2024 06:07
@pavjacko pavjacko merged commit df820c7 into release/1.0 Jun 19, 2024
1 check passed
@pavjacko pavjacko deleted the fix/build-shouldnt-generate branch June 19, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants