Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'info' task using envinfo #1632

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

added 'info' task using envinfo #1632

wants to merge 6 commits into from

Conversation

ElenaDiachenko
Copy link
Contributor

Description

  • Small description

Related issues

Npm releases

n/a

Screenshot 2024-07-17 at 23 26 13

@ElenaDiachenko ElenaDiachenko marked this pull request as draft July 17, 2024 20:28
@ElenaDiachenko ElenaDiachenko self-assigned this Jul 19, 2024
@ElenaDiachenko ElenaDiachenko added this to the 1.0 milestone Jul 22, 2024
@ElenaDiachenko ElenaDiachenko changed the base branch from release/1.0 to main July 22, 2024 09:02
@ElenaDiachenko ElenaDiachenko marked this pull request as ready for review July 22, 2024 11:35
@ElenaDiachenko ElenaDiachenko changed the title added 'info env' task using envinfo added 'info' task using envinfo Jul 22, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElenaDiachenko consider changing the scope of tests.

instead of testing what could be considered an internal structure of task:

import { _checkAndConfigureTargetSdk, _formatObject, _getCliVersions } from '../taskInfo';

import task itself

import taskInfo from '../taskInfo';

and create test case scenarios around it.

that way what is tested (taskInfo) is treated as blackbox because nobody will use _checkAndConfigureTargetSdk, _formatObject, _getCliVersions directly (those should be non-expoted methods internal to task).
the method you want to test in this case would be taskClean.fn() because that's the public api called by anybody who uses this task

example:
https://github.com/flexn-io/renative/blob/main/packages/engine-core/src/tasks/global/__tests__/taskClean.test.ts#L35

@pavjacko pavjacko modified the milestones: 1.0, 1.1 Jul 23, 2024
@pauliusguzas pauliusguzas added e2e and removed e2e labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants