sdk fixes & feats #771
Merged
sdk fixes & feats #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaiblaga89
approved these changes
Dec 23, 2021
| @@ -523,7 +524,7 @@ const _parsePluginTemplateDependencies = (c, customPluginTemplates, scope = 'roo | |||
| Object.keys(customPluginTemplates).forEach((k) => { | |||
| const val = customPluginTemplates[k]; | |||
| if (val.npm) { | |||
| const npmDep = c.files.project.package?.dependencies[val.npm] | |||
| const npmDep = c.files.project.package?.dependencies?.[val.npm] | |||
| || c.files.project.package?.devDependencies[val.npm]; | |||
There was a problem hiding this comment.
why not devDependencies?.[val.npm] as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
0.x.0Add new functionality + addDEPRECATEDwarning to existing fuctionality0.[x+1].0Remove deprecated functionalityI have tested my changes on:
ReNative project directly:
New project:
Existing Project created with previous version of renative: