fix: electron build #825
Merged
fix: electron build #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavjacko
approved these changes
Mar 4, 2022
* canary: [chore] update lint rules 0.36.0-canary.2 merge prep up remove gems from template helloworld 0.35.4-feat-rn-upgrade.2 increase max available space size on building android bundles 0.35.4-feat-rn-upgrade.1 remove broken overriden, and android-v8 dep to template 0.35.4-feat-rn-upgrade.0 rn 0.67.2 upgrade, react-native-tvos 0.63.3 uphrade duplicate engine and rename to rnv-engine-rn-63 # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#784 (comment)
Electron menu was taking up full screen, babel-preset-expo was missing even though it is being used in withRnvBabel and google-cast was crashing electron builds, because native module is not supported on web based builds
Breaking Changes
0.x.0Add new functionality + addDEPRECATEDwarning to existing fuctionality0.[x+1].0Remove deprecated functionalityI have tested my changes on:
ReNative project directly:
New project:
Existing Project created with previous version of renative: