Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS Migrations #836

Merged
merged 16 commits into from Mar 21, 2022
Merged

TS Migrations #836

merged 16 commits into from Mar 21, 2022

Conversation

pavjacko
Copy link
Member

@pavjacko pavjacko commented Mar 20, 2022

Description

Migrates following packages to full TypeScript:

  • renative
  • renative-template-hello-world
  • renative-template-blank

And sets mixed TS/JS support for gradual migration of other packages

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #836 (27d8952) into canary (6e62c1b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           canary     #836   +/-   ##
=======================================
  Coverage   26.17%   26.18%           
=======================================
  Files          29       29           
  Lines        3350     3349    -1     
  Branches      815      815           
=======================================
  Hits          877      877           
+ Misses       1780     1779    -1     
  Partials      693      693           
Flag Coverage Δ
rnvunittests 26.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rnv/src/core/systemManager/npmUtils.js 6.04% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e62c1b...27d8952. Read the comment docs.

@odemolliens odemolliens mentioned this pull request Mar 21, 2022
@pavjacko pavjacko merged commit 734e252 into canary Mar 21, 2022
@pavjacko pavjacko deleted the feat/renative-ts branch March 21, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants