Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add support for dynamic plugin fonts #914

Merged
merged 2 commits into from Sep 17, 2022
Merged

Conversation

pavjacko
Copy link
Member

Description

  • Describe the nature of the work / fix

example in renative.plugin.json

"fontSources": [
      "{{resolvePackage(react-native-vector-icons)}}/Fonts",
 ]
  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@pavjacko pavjacko merged commit 17a4779 into canary Sep 17, 2022
@pavjacko pavjacko added this to the 0.37 milestone Jun 20, 2023
@pavjacko pavjacko deleted the feat/plugin-fonts branch February 14, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant