Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: template-starter tv with bundle assets error #916

Merged
merged 3 commits into from Sep 21, 2022
Merged

fix: template-starter tv with bundle assets error #916

merged 3 commits into from Sep 21, 2022

Conversation

locksten
Copy link
Collaborator

Description

Fixes #876

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@locksten locksten mentioned this pull request Sep 19, 2022
Closed
@pavjacko
android support for whitespace workaround
c79b3d1
@pavjacko
Merge branch 'canary' into fix/template-starter-tv-with-bundle-assets…
b6a47e5 
…-error

* canary:
  android support for whitespace workaround
  0.37.0-canary.2
  add support for font name spaces
  fix: make tv tests work
  fix: androidtv and firetv app icon sizes
  feat(Info.plist): Allow integer values to be inserted into Info.plist file
  fix: rename test id
  fix: rename test id
  fix: move test id from icon to button
  chore:change test id's
  chore:change test id's
  fix: fix tvos tests
  chore: update e2e tests

# Conflicts:
#	packages/template-starter/src/entry/index.ts
@pavjacko pavjacko merged commit 8e39246 into canary Sep 21, 2022
@pavjacko pavjacko deleted the fix/template-starter-tv-with-bundle-assets-error branch September 21, 2022 21:21
@pavjacko pavjacko added this to the 0.37 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurimasmi aurimasmi Awaiting requested review from aurimasmi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.37
Development

Successfully merging this pull request may close these issues.

[tvOS, AndroidTV] Template starter package test scheme build can't be launched with "bundleAssets": true
2 participants
@locksten @pavjacko