Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several enhancements #553

Merged
merged 6 commits into from
Apr 12, 2019
Merged

Several enhancements #553

merged 6 commits into from
Apr 12, 2019

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Apr 9, 2019

@damienflament
Copy link

damienflament commented Apr 9, 2019

I think implementing that layout using a <table> is not semantically correct. I would rather have used the CSS display property with its values table-row, table-column, table-cell, etc.

@almarklein
Copy link
Member Author

almarklein commented Apr 9, 2019

I think implementing that layout using a <table> is not semantically correct.

Which one? The FormLayout was implemented with <table> before this PR, but afterwards, no layout uses table anymore.

@almarklein almarklein mentioned this pull request Apr 9, 2019
20 tasks
@damienflament
Copy link

Arf. My bad. I misread the code within your PR and mixed up the old BaseTableLayout implementation and the new GridLayout.

@almarklein
Copy link
Member Author

Hehe, no problem. Thanks for speaking up nonetheless :)

@almarklein
Copy link
Member Author

merging now, will look at easier freezing in a separate PR.

@almarklein almarklein merged commit 64900bc into master Apr 12, 2019
@almarklein almarklein deleted the dev branch April 12, 2019 09:23
@almarklein
Copy link
Member Author

Also see #559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outernode and node documentation for developers Implement form layout using CSS instead of TABLE
2 participants