Set default user-agent. Fixes #156

flickr · Mar 22, 2023 · dc79a7a · dc79a7a
1 parent 96ff402
commit dc79a7a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/request.js b/lib/request.js
@@ -5,6 +5,7 @@
 
 var request = require('superagent');
 var parse = require('querystring').parse;
+var version = require('../package.json').version;
 
 /**
  * Subclass superagent's Request class so that we can add
@@ -19,6 +20,9 @@ function Request(method, url) {
 
 	// keep track of all request params for oauth signing
 	this.params = {};
+
+	// superagent no longer sets a default user agent header
+	this.set('user-agent', 'flickr-sdk/' + version);
 }
 
 Request.prototype = Object.create(request.Request.prototype);

diff --git a/test/request.js b/test/request.js
@@ -13,6 +13,14 @@ describe('lib/request', function () {
 		assert(subject('GET', 'http://www.example.com') instanceof Request);
 	});
 
+	it('has a default user agent', function () {
+		const req = subject('GET', 'http://www.example.com');
+
+		assert.strictEqual(req.get('user-agent'),
+			'flickr-sdk/' + process.env.npm_package_version
+		);
+	});
+
 	it('supports request(url, callback)', function () {
 		var end = sinon.stub(subject.Request.prototype, 'end').returnsThis();
 		var spy = sinon.spy();