Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarking ahash dep #6

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

Manishearth
Copy link
Contributor

The original dep has been yanked.

criterion is also out of date and has future incompatibility warnings, it would be nice to update that as well but it seems more involved.

@Manishearth
Copy link
Contributor Author

(Also checking in: @flier do you consider this crate to still be maintained? I totally understand that the lack of activity is not necessarily a huge signal for a crate you may consider "done", but just want to get a temperature check before I spend more effort on fixing miri errors and such)

@flier
Copy link
Owner

flier commented Jul 28, 2023

(Also checking in: @flier do you consider this crate to still be maintained? I totally understand that the lack of activity is not necessarily a huge signal for a crate you may consider "done", but just want to get a temperature check before I spend more effort on fixing miri errors and such)

In general, the crate is "done", because the upstream repo is in the maintenance mode, but if you need update the crate or find some major bug, I can merge the PR or fix the bug for a new release :)

@flier flier merged commit 45484ad into flier:master Jul 28, 2023
1 check failed
@Manishearth Manishearth deleted the crate-updates branch July 28, 2023 04:57
@Manishearth
Copy link
Contributor Author

Thanks. I've noticed this crate fails under miri and wanted to work on debugging it but I don't want to do it unless I know the crate is maintained 😄

I might look into this later then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants