Fix configure option handling #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 3, 2020 14:43
…tion, -noproxy, -telnetoptions
bovine
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -tlsauthtype and -transferencoding options were missing from the optionTable/configTable. That was causing the options after -tlsauthpassword to be broken.
-ftpsslccc was missing the last 'c'.
The curl_off_t code was just copy&paste from the long version. This means that offsets larger than ~2GBytes didn't work on platforms where long is 32 bits in size.
Finally the -postfieldsize option was not really implemented. The last patch in this set fixes this. This option is mandatory for POST requests using HTTP 1.0 when using libcurl >= 7.66.0 (see https://curl.haxx.se/libcurl/c/CURLOPT_POST.html).