New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for Windows nmake builds #17
Conversation
So do not run vcpkg at all if action cache reports true.
I think I'm done with this. Both Tcl and curl are cached now so subsequent runs are much faster. Please review and merge. |
Great work. What would you think about renaming CURLDEPSDIR to ZLIBDIR, since it is currently only used to find zlib? |
The original reason for CURLDEPSDIR was that there are multiple additional dependencies depending on what options curl is built with that require additional libraries. The curl (as opposed to the vcpkg version of it) visual c++ build expects these to be in a single directory "deps" (see winbuild/readme.md in the curl sources). CURLDEPSDIR reflects that so at some point building tclcurl with the additional options (and subsequent additional dependencies) will not require multiple "ZLIBDIR" like options to be set. Now vcpkg unfortunately uses a different directory layout which will complicate matters if we ever get to that point of additional options but that's a bridge to cross at some later point. Hope that is clearer than mud :-) |
Adds a workflow for Windows using the nmake based build system including build, install and test steps.