Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libMangoApp.so not found in default configuration #795

Closed
smcv opened this issue Jun 23, 2022 · 0 comments · Fixed by #796
Closed

libMangoApp.so not found in default configuration #795

smcv opened this issue Jun 23, 2022 · 0 comments · Fixed by #796

Comments

@smcv
Copy link
Contributor

smcv commented Jun 23, 2022

With -Dprepend_libdir_vk=true (default), the JSON manifests for both layers list the layer by its absolute path in ld_libdir_mangohud, using the $LIB dynamic string token to let 32- and 64-bit layers be co-installed. If configured with -Dappend_libdir_mangohud=true (also the default), then the path given is ${libdir}/mangohud.

libMangoHud.so is correctly installed into either ${libdir} or ${libdir}/mangohud depending on the value of append_libdir_mangohud, so it is consistent with its JSON manifest. However, libMangoApp.so is still installed directly into ${libdir}, even when its JSON manifest says it's in ${libdir}/mangohud.

The Debian packaging has a simple patch for this, which I'll send as a PR in a moment.

smcv added a commit to smcv/MangoHud-branches that referenced this issue Jun 23, 2022
This makes the installation path adapt correctly to the value of
the append_libdir_mangohud option, which defaults to putting it in a
subdirectory ${libdir}/mangohud. Without this, the path in the JSON
manifest (which does respect append_libdir_mangohud) is inconsistent
with the actual location of the library.

Resolves: flightlessmango#795
Co-authored-by: Simon McVittie <smcv@collabora.com>
jackun pushed a commit that referenced this issue Jul 13, 2022
This makes the installation path adapt correctly to the value of
the append_libdir_mangohud option, which defaults to putting it in a
subdirectory ${libdir}/mangohud. Without this, the path in the JSON
manifest (which does respect append_libdir_mangohud) is inconsistent
with the actual location of the library.

Resolves: #795
Co-authored-by: Simon McVittie <smcv@collabora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant