Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail build version.h not found when build more than 18threads (18 ok, 19 fails) #862

Closed
sl1pkn07 opened this issue Dec 1, 2022 · 4 comments · Fixed by #948
Closed

fail build version.h not found when build more than 18threads (18 ok, 19 fails) #862

sl1pkn07 opened this issue Dec 1, 2022 · 4 comments · Fixed by #948

Comments

@sl1pkn07
Copy link

sl1pkn07 commented Dec 1, 2022

i have 48threads machine

if try to build the project with all threads active fail build

In file included from ../src/amdgpu.cpp:7:
../src/overlay.h:10:10: fatal error: version.h: No such file or directory
   10 | #include "version.h"
      |          ^~~~~~~~~~~

if set jobs (-j) lower than 19, builds ok

i think the command for generate the version.h file should be created in configure time instead of build time

greetings
@flightlessmango
Copy link
Owner

i think the command for generate the version.h file should be created in configure time instead of build time

But that's already the case?

@sl1pkn07
Copy link
Author

sl1pkn07 commented Dec 13, 2022 •
edited

no. "meson setup foo" as-sis not generated the file, but yes when do "meson compile foo"

└───╼  meson compile --verbose
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -v
[1/56] c++ -Isrc/libMangoHud_dlsym.so.p -Isrc -I../MangoHud/src -I../MangoHud/include -fvisibility=hidden -flto=auto -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -std=c++14 -Werror=return-type -Wno-unused-parameter -fno-math-errno -fno-trapping-math -Wno-non-virtual-dtor -Wno-missing-field-initializers -Wno-format-truncation -march=native -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/tmp/makepkg/sl1-mangohud-git/src=/usr/src/debug/sl1-mangohud-git -fPIC -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS '-DPACKAGE_VERSION="v0.6.8"' -DSPDLOG_COMPILED_LIB -DNDEBUG -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -D_GNU_SOURCE -DHAVE_PTHREAD -DUSE_GCC_ATOMIC_BUILTINS -DHAVE_TIMESPEC_GET -DHAVE___BUILTIN_BSWAP32 -DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS -DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT -DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_UNREACHABLE '-DMANGOHUD_ARCH="64bit"' -DHAVE_NVML -DHAVE_XNVCTRL -DHAVE_X11 -DHAVE_DBUS -MD -MQ src/libMangoHud_dlsym.so.p/hook_dlsym.cpp.o -MF src/libMangoHud_dlsym.so.p/hook_dlsym.cpp.o.d -o src/libMangoHud_dlsym.so.p/hook_dlsym.cpp.o -c ../MangoHud/src/hook_dlsym.cpp
[2/56] c++ -Isrc/libMangoHud_dlsym.so.p -Isrc -I../MangoHud/src -I../MangoHud/include -fvisibility=hidden -flto=auto -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -std=c++14 -Werror=return-type -Wno-unused-parameter -fno-math-errno -fno-trapping-math -Wno-non-virtual-dtor -Wno-missing-field-initializers -Wno-format-truncation -march=native -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/tmp/makepkg/sl1-mangohud-git/src=/usr/src/debug/sl1-mangohud-git -fPIC -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS '-DPACKAGE_VERSION="v0.6.8"' -DSPDLOG_COMPILED_LIB -DNDEBUG -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -D_GNU_SOURCE -DHAVE_PTHREAD -DUSE_GCC_ATOMIC_BUILTINS -DHAVE_TIMESPEC_GET -DHAVE___BUILTIN_BSWAP32 -DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS -DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT -DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_UNREACHABLE '-DMANGOHUD_ARCH="64bit"' -DHAVE_NVML -DHAVE_XNVCTRL -DHAVE_X11 -DHAVE_DBUS -MD -MQ src/libMangoHud_dlsym.so.p/real_dlsym.cpp.o -MF src/libMangoHud_dlsym.so.p/real_dlsym.cpp.o.d -o src/libMangoHud_dlsym.so.p/real_dlsym.cpp.o -c ../MangoHud/src/real_dlsym.cpp
[3/56] c++ -Isrc/libMangoHud_dlsym.so.p -Isrc -I../MangoHud/src -I../MangoHud/include -fvisibility=hidden -flto=auto -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -std=c++14 -Werror=return-type -Wno-unused-parameter -fno-math-errno -fno-trapping-math -Wno-non-virtual-dtor -Wno-missing-field-initializers -Wno-format-truncation -march=native -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/tmp/makepkg/sl1-mangohud-git/src=/usr/src/debug/sl1-mangohud-git -fPIC -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS '-DPACKAGE_VERSION="v0.6.8"' -DSPDLOG_COMPILED_LIB -DNDEBUG -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -D_GNU_SOURCE -DHAVE_PTHREAD -DUSE_GCC_ATOMIC_BUILTINS -DHAVE_TIMESPEC_GET -DHAVE___BUILTIN_BSWAP32 -DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS -DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT -DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_UNREACHABLE '-DMANGOHUD_ARCH="64bit"' -DHAVE_NVML -DHAVE_XNVCTRL -DHAVE_X11 -DHAVE_DBUS -MD -MQ src/libMangoHud_dlsym.so.p/elfhacks.cpp.o -MF src/libMangoHud_dlsym.so.p/elfhacks.cpp.o.d -o src/libMangoHud_dlsym.so.p/elfhacks.cpp.o -c ../MangoHud/src/elfhacks.cpp
[4/56] /usr/bin/glslangValidator -V -x -o src/overlay.frag.spv.h ../MangoHud/src/overlay.frag
../MangoHud/src/overlay.frag
[5/56] /usr/bin/glslangValidator -V -x -o src/overlay.vert.spv.h ../MangoHud/src/overlay.vert
../MangoHud/src/overlay.vert
[6/56] /usr/bin/meson --internal vcstagger ../MangoHud/version.h.in version.h v0.6.8 /tmp/makepkg/sl1-mangohud-git/src/MangoHud @VCS_TAG@ '(.*)' /usr/bin/git describe --tags --dirty=+

@flightlessmango
Copy link
Owner

Do we have control over that? Seems to me like Meson chooses what is in setup and what is in compile

evelikov added a commit to evelikov/MangoHud that referenced this issue Mar 10, 2023
@evelikov
meson: explicitly annotate version.h as dependency
2d2f9e9 
Currently we list the custom_target (aka vcs_tag() as part of the
sources. Although since it's not an explicit dependency meson/ninja are
free to compile the C/C++ files, before the file is generated.

Closes: flightlessmango#862
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
@evelikov evelikov mentioned this issue Mar 10, 2023
Merged
flightlessmango pushed a commit that referenced this issue Mar 13, 2023
@evelikov @flightlessmango
meson: explicitly annotate version.h as dependency
5c86369 
Currently we list the custom_target (aka vcs_tag() as part of the
sources. Although since it's not an explicit dependency meson/ninja are
free to compile the C/C++ files, before the file is generated.

Closes: #862
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
@evelikov
Copy link
Contributor

evelikov commented Mar 17, 2023 •
edited

Edit: nvm misread the comment.

KyleGospo pushed a commit to KyleGospo/MangoHud that referenced this issue Jul 15, 2023
@evelikov @ecin1kgos1
meson: explicitly annotate version.h as dependency
b12c8e1 
Currently we list the custom_target (aka vcs_tag() as part of the
sources. Although since it's not an explicit dependency meson/ninja are
free to compile the C/C++ files, before the file is generated.

Closes: flightlessmango#862
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
gort818 pushed a commit that referenced this issue Jul 17, 2023
@evelikov @gort818
meson: explicitly annotate version.h as dependency
01de24a 
Currently we list the custom_target (aka vcs_tag() as part of the
sources. Although since it's not an explicit dependency meson/ninja are
free to compile the C/C++ files, before the file is generated.

Closes: #862
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

meson: explicitly annotate version.h as dependency evelikov/MangoHud
3 participants
@sl1pkn07 @evelikov @flightlessmango