Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d4aa74c breaks capturing with obs-vkcapture #933

Closed
hannesmann opened this issue Feb 20, 2023 · 1 comment · Fixed by #978
Closed

d4aa74c breaks capturing with obs-vkcapture #933

hannesmann opened this issue Feb 20, 2023 · 1 comment · Fixed by #978

Comments

@hannesmann
Copy link
Contributor

Commit d4aa74c breaks OpenGL games when using obs-vkcapture. Can be easily reproduced by launching glxgears with obs-gamecapture mangohud glxgears.

I'm not really sure what would cause this. Using gdb shows that the application hangs in clock_gettime which makes no sense.
evelikov added a commit to evelikov/MangoHud that referenced this issue Apr 2, 2023
@evelikov
meson: restrict most libMangoHud.so symbols
e8fe219 
With the introduction of the static library, we forgot the version
script. As a result we were spilling all the internal symbols.

Fixes: d4aa74c ("Create static and shared libs separately")
Closes: flightlessmango#933
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
evelikov added a commit to evelikov/MangoHud that referenced this issue Apr 2, 2023
@evelikov
meson: restrict most libMangoHud.so symbols
d594004 
With the introduction of the static library, we forgot the version
script. As a result we were spilling all the internal symbols.

Fixes: d4aa74c ("Create static and shared libs separately")
Closes: flightlessmango#933
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
@evelikov evelikov mentioned this issue Apr 2, 2023
Merged
@evelikov
Copy link
Contributor

evelikov commented Apr 2, 2023 •
edited

Haven't tried obs-vkcapture to definitively confirm, but the PR should fix the issue. Can you give it a try?

flightlessmango pushed a commit that referenced this issue Apr 3, 2023
@evelikov @flightlessmango
meson: restrict most libMangoHud.so symbols
1b3f8b2 
With the introduction of the static library, we forgot the version
script. As a result we were spilling all the internal symbols.

Fixes: d4aa74c ("Create static and shared libs separately")
Closes: #933
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
KyleGospo pushed a commit to KyleGospo/MangoHud that referenced this issue Jul 15, 2023
@evelikov @ecin1kgos1
meson: restrict most libMangoHud.so symbols
47147b7 
With the introduction of the static library, we forgot the version
script. As a result we were spilling all the internal symbols.

Fixes: d4aa74c ("Create static and shared libs separately")
Closes: flightlessmango#933
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
gort818 pushed a commit that referenced this issue Jul 17, 2023
@evelikov @gort818
meson: restrict most libMangoHud.so symbols
fee7b78 
With the introduction of the static library, we forgot the version
script. As a result we were spilling all the internal symbols.

Fixes: d4aa74c ("Create static and shared libs separately")
Closes: #933
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

meson: restrict most libMangoHud.so symbols evelikov/MangoHud
2 participants
@evelikov @hannesmann